Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify image tag when submitting batch tasks #1330

Merged
merged 1 commit into from
May 9, 2024

Conversation

tamuri
Copy link
Collaborator

@tamuri tamuri commented May 7, 2024

  • overrides default image tag, which is set in batch configuration
  • allows user to run tasks on an older image (e.g. with python 3.8 support)

Fixes #1328

@tamuri tamuri requested review from giordano and matt-graham May 8, 2024 08:10
- overrides default image tag, which is set in batch configuration
- allows user to run tasks on an older image (e.g. with python 3.8 support)
@tamuri tamuri force-pushed the tamuri/set-batch-container-tag branch from 0d518ab to fcb7864 Compare May 8, 2024 08:10
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but do I understand correctly that the image tag could also be changed in the config file? If so, should we recommend using that?

@tamuri
Copy link
Collaborator Author

tamuri commented May 8, 2024

Thanks. These particular settings are read from the Azure Batch resource, not the user's personal config. I think it's better to set the run environment on the server-side, and let the user override for specific runs because e.g. they are running some old code. In the general case, they should always be using the one we set.

@tamuri tamuri removed the request for review from matt-graham May 8, 2024 09:17
@tamuri tamuri merged commit 3bdba8c into master May 9, 2024
56 checks passed
@tamuri tamuri deleted the tamuri/set-batch-container-tag branch May 9, 2024 09:08
joehcollins pushed a commit that referenced this pull request May 9, 2024
- overrides default image tag, which is set in batch configuration
- allows user to run tasks on an older image (e.g. with python 3.8 support)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branches using older versions of python cannot submit jobs to azure
2 participants