Analysis: Refactoring to improve readibility + efficiency. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating to wrap main script in if__name__=="main" statement. Worked with @Jennivine. |
|
Updating to simplify creation of results array in workflow1.py. Worked with @Jennivine. |
|
Simplifying calculation + printing of number of critical results. Worked with @Jennivine. |
|
Updating workflow2.py to import + use read_file function from workflow1.py. Worked with @Jennivine. |
|
Adding utils.py file to house functions used by both workflows. Worked with @Jennivine. |
|
Wrapping script in workflow2.py in if name == "main" statement. Worked with @Jennivine. |
|
Simplifying calculation of dsum with numpy in workflow2.py. Worked with @Jennivine. |
L-Amos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating + implementing read_files function in workflow1.py. Answers UCL-COMP0233-24-25/RSE-Classwork#42. Worked with @Jennivine.