Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda → miniforge. Make anaconda explicitly red. #444

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

samcunliffe
Copy link
Member

Solves

Deliberately does not address

Even if we decide to recommend uv over conda-forge we want to make the distinction.

Picky comments about language and clarity very gratefully received.

Solves #443. Deliberately does not address #419. Even if we decide to
recommend `uv` over `conda-forge` we want to make the distinction.
@samcunliffe samcunliffe added bug Something isn't working documentation Improvements or additions to documentation labels Sep 5, 2024
@samcunliffe samcunliffe requested review from dpshelio and a team September 5, 2024 08:28
paddyroddy
paddyroddy previously approved these changes Sep 5, 2024
Copy link
Member

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫐

docs/pages/virtual.md Outdated Show resolved Hide resolved
docs/pages/virtual.md Outdated Show resolved Hide resolved
docs/pages/virtual.md Outdated Show resolved Hide resolved
docs/pages/virtual.md Show resolved Hide resolved
samcunliffe and others added 2 commits September 5, 2024 10:54
@samcunliffe samcunliffe dismissed paddyroddy’s stale review September 5, 2024 09:58

Don't want approval to lead to accidental early merge.

docs/pages/virtual.md Outdated Show resolved Hide resolved
Co-authored-by: David Pérez-Suárez <[email protected]>
@dstansby dstansby merged commit ae97b7c into main Sep 5, 2024
14 checks passed
@dstansby dstansby deleted the sc/conda-forge-miniforge-anaconda branch September 5, 2024 11:08
@dstansby
Copy link
Member

dstansby commented Sep 5, 2024

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should not be recommending standard conda with the default channels.
4 participants