Drop 3.9 support
#360
Merged
Drop 3.9 support
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
requested review from
samcunliffe,
dstansby,
matt-graham and
p-j-smith
paddyroddy
added
bug
|
I'm 👍 👎 about this. I agree with the NEP argument. But some non-numpy projects could presumably run just fine with 3.9. I'll go with the majority. Edit: what dstansby said. |
dstansby
requested changes
Apr 25, 2024
There was a problem hiding this comment.
I'm personally 👎 on dropping this (it wouldn't be that much more effort to support 3.8/3.9), but happy to go with a consesus the other way. I agree with #359 (comment), in that we should come to a consensus decision to choose to follow either SPEC0 or NEP29 before making this change.
dstansby
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recent change on GitHub Actions actions/setup-python#850 our tests are currently failing #359.
Previously we were following NEP29 which is why we never supported
3.8. My suggestion is to drop3.9which means nothing else has to change.The alternative is to do @dstansby's suggestion, but I think this is low-key complicated when involving our
toxsetup too. Personally, I don't think it's worth it, and we should fix the tests ASAP.