-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
340/cran release/update version #341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
📕 Preview documentation for this PR has been cleaned up. |
@d-morrison all checks pass, but I'm getting the following notes in check_win_devel(). The first one seems just informational and I added a note to cran_comments.Rd about the spelling and previously archived version. However, I'm not sure what to do with the second one. I see a *** checking CRAN incoming feasibility ... NOTE** New submission Package was archived on CRAN Possibly misspelled words in DESCRIPTION: Unknown, possibly misspelled, fields in DESCRIPTION: CRAN repository db overrides: On Internet access. Suggests or Enhances not in mainstream repositories: *** checking HTML version of manual ... NOTE** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see question below and notes in chat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on getting us back on CRAN! I added a couple more commits to implement the post-acceptance steps from https://r-pkgs.org/release.html#sec-release-post-acceptance, since those instructions don't quite map onto our current workflow.
Updating version number, CRAN comments, and any issues ahead of submission