Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

340/cran release/update version #341

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Conversation

kristinawlai
Copy link
Collaborator

Updating version number, CRAN comments, and any issues ahead of submission

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
R/graph.decay.curves.R 80.00% <ø> (ø)
R/sim.cs.R 0.00% <ø> (ø)

Copy link

github-actions bot commented Jan 23, 2025

📕 Preview documentation for this PR has been cleaned up.

@kristinawlai
Copy link
Collaborator Author

@d-morrison all checks pass, but I'm getting the following notes in check_win_devel(). The first one seems just informational and I added a note to cran_comments.Rd about the spelling and previously archived version. However, I'm not sure what to do with the second one. I see a {} in sim.cs.Rd, but I can't figure out where it is coming from in sim.cs.R.

*** checking CRAN incoming feasibility ... NOTE**
Maintainer: 'Kristina Lai [email protected]'

New submission

Package was archived on CRAN

Possibly misspelled words in DESCRIPTION:
Serological (3:40)
seroconversions (15:5)
seroincidence (16:28)

Unknown, possibly misspelled, fields in DESCRIPTION:
'Remotes'

CRAN repository db overrides:
X-CRAN-Comment: Archived on 2024-11-26 for policy violation.

On Internet access.

Suggests or Enhances not in mainstream repositories:
devtag

*** checking HTML version of manual ... NOTE**
Found the following HTML validation problems:
sim.cs.html:161:1 (sim.cs.Rd:76): Warning: trimming empty

@kristinawlai kristinawlai marked this pull request as ready for review January 23, 2025 22:31
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see question below and notes in chat

NEWS.md Show resolved Hide resolved
Copy link
Member

@d-morrison d-morrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on getting us back on CRAN! I added a couple more commits to implement the post-acceptance steps from https://r-pkgs.org/release.html#sec-release-post-acceptance, since those instructions don't quite map onto our current workflow.

@d-morrison d-morrison merged commit 0b05977 into main Jan 27, 2025
15 of 16 checks passed
@d-morrison d-morrison deleted the 340/CRAN-release/update-version branch January 27, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants