Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- added snapshot test for df_to_array() #276

Merged
merged 40 commits into from
Sep 30, 2024
Merged

- added snapshot test for df_to_array() #276

merged 40 commits into from
Sep 30, 2024

Conversation

d-morrison
Copy link
Member

also fixed deprecation warning for dplyr::select()

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
R/df_to_array.R 76.47% <100.00%> (+76.47%) ⬆️

@d-morrison d-morrison requested a review from a team September 26, 2024 05:37
@@ -8,7 +8,7 @@
#'
#' @keywords internal
#'
df.to.array <- function(
df.to.array <- function( # nolint: object_name_linter
Copy link
Member Author

@d-morrison d-morrison Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we skip linting this particular variable name because it is the deprecated version of the renamed function, and thus cannot be renamed here.

chrisorwa
chrisorwa previously approved these changes Sep 29, 2024
Copy link
Collaborator

@chrisorwa chrisorwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@d-morrison d-morrison requested a review from a team September 30, 2024 07:52
@d-morrison d-morrison merged commit fc4fa2a into main Sep 30, 2024
15 checks passed
@d-morrison d-morrison deleted the test-df_to_array branch September 30, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants