Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
updateQuery
(for subscriptions) orupdateQueries
(for mutations), you have to return an object whose keys will be matched with all currently known query names. That's why we have to sayallTodoes
reverse()
statement. I think this order is more natural (latest todo at the bottom of the list).Current limitations:
updateQueries
instead ofrefetch()
, however that is undergoing significant changes at the moment.Not sure if you consider #1 to be fixed by this.
All in all, I'd say these are not huge issues and can be fixed once the above two changes are live.
Thanks for putting this together so quickly! 💪