Bump AsyncKeyedLock to 7.0.1 #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarkCiliaVincenti package updates normally go through Dependabot PRs, it's easier to track them that way. Any particular reason you decided to create a PR for this version? |
|
Actually yes, I forgot to apply. Since AsyncKeyedLocker 7.0.0 there is no need to specify pooling options as defaults of pool size = 20 and initial fill of 1 are applied, the same numbers used by DiscordChatExporter. Thus these settings can be removed now, or you can prefer to leave them there. |
|
Can you please remove them in this PR? Thanks |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.