Allow hiding of link underlines

See microsoft/vscode#95080
Tyriar · Apr 18, 2020 · 48f5799 · 48f5799
1 parent 2836dcb
commit 48f5799
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/src/browser/Linkifier2.ts b/src/browser/Linkifier2.ts
@@ -184,7 +184,9 @@ export class Linkifier2 implements ILinkifier2 {
     const range = link.range;
     const scrollOffset = this._bufferService.buffer.ydisp;
 
-    this._onLinkHover.fire(this._createLinkHoverEvent(range.start.x - 1, range.start.y - scrollOffset - 1, range.end.x, range.end.y - scrollOffset - 1, undefined));
+    if (!link.hideUnderline) {
+      this._onLinkHover.fire(this._createLinkHoverEvent(range.start.x - 1, range.start.y - scrollOffset - 1, range.end.x, range.end.y - scrollOffset - 1, undefined));
+    }
     element.classList.add('xterm-cursor-pointer');
 
     if (link.hover) {

diff --git a/src/browser/Types.d.ts b/src/browser/Types.d.ts
@@ -172,6 +172,7 @@ interface ILinkProvider {
 interface ILink {
   range: IBufferRange;
   text: string;
+  hideUnderline?: boolean;
   activate(event: MouseEvent, text: string): void;
   hover?(event: MouseEvent, text: string): void;
   leave?(event: MouseEvent, text: string): void;

diff --git a/typings/xterm.d.ts b/typings/xterm.d.ts
@@ -1120,6 +1120,11 @@ declare module 'xterm' {
      */
     text: string;
 
+    /**
+     * Whether to hide the link's underline.
+     */
+    hideUnderline?: boolean;
+
     /**
      * Calls when the link is activated.
      * @param event The mouse event triggering the callback.