Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate "jp" #2843

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Deprecate "jp" #2843

merged 2 commits into from
Feb 4, 2025

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Feb 2, 2025

  • Hide "jp" from available languages
  • Add Japanese messages for those who chose "jp" instead of "ja" (you can remove them after it turns to be unnecessary)
  • Tweak message for unsupported languages (doesn't support → can't provide translations)

Gerrit0
Gerrit0 reviewed Feb 2, 2025
View reviewed changes
src/lib/application.ts Outdated Show resolved Hide resolved
@tats-u
Copy link
Contributor Author

tats-u commented Feb 3, 2025 •
edited
Loading

  • Removed the removal notice message
  • Split the commit into 2; by this you can just revert 'Deprecate "jp"' after dropping support for "jp"

@Gerrit0 Gerrit0 changed the base branch from master to dev February 4, 2025 03:43
@Gerrit0 Gerrit0 merged commit 304ddd2 into TypeStrong:dev Feb 4, 2025
8 checks passed
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 4, 2025

Thanks!

@tats-u tats-u deleted the deprecate-jp branch February 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit0 Gerrit0 Gerrit0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tats-u @Gerrit0