Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perf] Don't get diagnostics if ignoreCompilerErrors is set #1032

Closed
Gerrit0 opened this issue May 7, 2019 · 1 comment
Closed

[Perf] Don't get diagnostics if ignoreCompilerErrors is set #1032

Gerrit0 opened this issue May 7, 2019 · 1 comment
Labels
good first issue Easier issue for first time contributors

Comments

@Gerrit0
Copy link
Collaborator

Gerrit0 commented May 7, 2019

Problem

When running typedoc --ignoreCompilerErrors --out docs src/ on the TypeDoc repo, 23% of the time is spent calling getSemanticDiagnostics. The output of this function is used (all errors are printed), but it doesn't make a difference in the generated documentation, and would be a major speed boost if removed.

Suggested Solution

Only call getSemanticDiagnostics if ignoreCompilerErrors is not specified.
@Gerrit0 Gerrit0 added the good first issue Easier issue for first time contributors label Dec 16, 2019
Gerrit0 added a commit that referenced this issue Dec 26, 2019
@Gerrit0
fix: Don't get compiler errors if they are ignored
c3d47b1 
Closes #1032
@Gerrit0
Copy link
Collaborator Author

Gerrit0 commented Dec 26, 2019

Released in v0.15.6

This was referenced Feb 5, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Easier issue for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gerrit0