Fix comment discovery on constructor params

Resolves #2636

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Unreleased
 
+### Bug Fixes
+
+-   Constructor parameters which share a name with a property on a parent class will no longer inherit the comment on the parent class, #2636.
+
 ## v0.26.4 (2024-07-10)
 
 ### Bug Fixes

src/lib/converter/comments/discovery.ts

@@ -412,6 +412,12 @@ function declarationToCommentNodeIgnoringParents(
     // ts.SourceFile is a counterexample
     if (!node.parent) return node;
 
+    // function foo(x: number)
+    //              ^^^^^^^^^
+    if (node.kind === ts.SyntaxKind.Parameter) {
+        return node;
+    }
+
     // const abc = 123
     //       ^^^
     if (node.parent.kind === ts.SyntaxKind.VariableDeclarationList) {

src/test/converter2/issues/gh2636.ts

@@ -0,0 +1,15 @@
+export abstract class A {
+    protected constructor(a: number) {
+        this.a = a;
+    }
+
+    /** a prop @hidden */
+    public readonly a: number;
+}
+
+export class B extends A {
+    /** @param a a comment */
+    public constructor(a: number) {
+        super(a);
+    }
+}

src/test/issues.c2.test.ts

@@ -1649,4 +1649,10 @@ describe("Issue Tests", () => {
         const project = convert();
         equal(project.children?.map((c) => c.name) || [], []);
     });
+
+    it("#2636 does not treat parameters as class properties", () => {
+        const project = convert();
+        const sig = querySig(project, "B.constructor");
+        equal(sig.parameters?.length, 1);
+    });
 });