Handle more skipLibCheck nonsense

Resolves #2438

CHANGELOG.md

@@ -1,5 +1,14 @@
 # Unreleased
 
+### Bug Fixes
+
+-   Fixed an infinite loop when `skipLibCheck` is used to ignore some compiler errors, #2438.
+-   `gitRevision` will now be replaced in `sourceLinkTemplate`, #2434.
+
+### Thanks!
+
+-   @swarnpallav
+
 ## v0.25.3 (2023-10-29)
 
 ### Features

src/lib/converter/symbols.ts

@@ -635,6 +635,9 @@ function convertClassOrInterface(
 
     // And finally, index signatures
     convertIndexSignature(reflectionContext, symbol);
+
+    // Normally this shouldn't matter, unless someone did something with skipLibCheck off.
+    return ts.SymbolFlags.Alias;
 }
 
 function convertProperty(

src/lib/converter/utils/symbols.ts

@@ -4,8 +4,13 @@ export function resolveAliasedSymbol(
     symbol: ts.Symbol,
     checker: ts.TypeChecker,
 ): ts.Symbol {
+    const seen = new Set<ts.Symbol>();
     while (ts.SymbolFlags.Alias & symbol.flags) {
         symbol = checker.getAliasedSymbol(symbol);
+
+        // #2438, with declaration files, we might have an aliased symbol which eventually points to itself.
+        if (seen.has(symbol)) return symbol;
+        seen.add(symbol);
     }
     return symbol;
 }

src/test/converter2/issues/gh2438.d.ts

@@ -0,0 +1,6 @@
+// This only produces no errors because of skipLibCheck
+export interface Bad {
+    badCode: true;
+}
+
+export type { Bad };

src/test/issues.c2.test.ts

@@ -1196,4 +1196,9 @@ describe("Issue Tests", () => {
             "Index comment.",
         );
     });
+
+    it("Handles recursive aliases without looping infinitely #2438", () => {
+        const bad = query(convert(), "Bad");
+        equal(bad.kind, ReflectionKind.Interface);
+    });
 });