Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed preloading of modules #258

Merged
merged 2 commits into from
Dec 29, 2016
Merged

Fixed preloading of modules #258

merged 2 commits into from
Dec 29, 2016

Conversation

Jontem
Copy link
Contributor

@Jontem Jontem commented Dec 29, 2016

Hi!

This is a PR for #257. I've added a unit test which verifies the solution. Unfortunately the typings for node doesn't contain the definition for _preloadModules so i had to cast to any. Maybe the typings could be added to? I saw that you authored the node typings.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 86.592% when pulling 7ed06f9 on Jontem:preload-modules into b2e6990 on TypeStrong:master.

1 similar comment
@coveralls
Copy link

coveralls commented Dec 29, 2016

Coverage Status

Coverage increased (+0.2%) to 86.592% when pulling 7ed06f9 on Jontem:preload-modules into b2e6990 on TypeStrong:master.

@jonaskello
Copy link
Contributor

Seems like there is a problem with node v4. Is there some other method that will work there?

@blakeembrey
Copy link
Member

@jonaskello The code is working, it's the test that's failing. tslint does not exist in node_modules at the time of the test. I would try pre-loading something else like typescript. See .travis.yml for the test configuration (note that tslint is explicitly uninstalled and NPM v2 had a nested structure, so no other module would be providing tslint to be required).

@coveralls
Copy link

coveralls commented Dec 29, 2016

Coverage Status

Coverage increased (+0.2%) to 86.592% when pulling 58e2cf4 on Jontem:preload-modules into b2e6990 on TypeStrong:master.

@Jontem
Copy link
Contributor Author

Jontem commented Dec 29, 2016

@blakeembrey i changed the test case to preload typescript instead. Looks good

@blakeembrey blakeembrey merged commit 50df9b1 into TypeStrong:master Dec 29, 2016
@Jontem Jontem deleted the preload-modules branch December 29, 2016 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants