Fix #1667 multiline function arguments support in REPL

[d9k]

Fixes #1667

[codecov]

Codecov Report

Merging #1677 (055c5c3) into main (b5aa55d) will increase coverage by 0.85%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
src/repl.ts	82.62% <100.00%> (+0.33%)	⬆️
src/index.ts	79.23% <0.00%> (+0.71%)	⬆️
src/esm.ts	85.18% <0.00%> (+1.85%)	⬆️
src/configuration.ts	93.75% <0.00%> (+2.67%)	⬆️
src/transpilers/swc.ts	79.24% <0.00%> (+3.77%)	⬆️
dist-raw/node-primordials.js	66.66% <0.00%> (+4.76%)	⬆️
dist-raw/node-esm-default-get-format.js	88.88% <0.00%> (+8.33%)	⬆️

[cspotcode]

Are there situations where TS7010: Function, which lacks return-type annotation, implicitly has an 'any' return type. is a good diagnostic that you want to see in the REPL? Situations where you don't want our recovery code logic to kick in, because you've entered complete code, but that error should be raised?

[cspotcode]

@d9k

I found a case where that diagnostic should be raised:

Playground
With strictNullChecks turned off:

(a: any) => a = null;

This is a complete line of code, so the REPL user should not see the ... continuation prompt. They should see the diagnostic.

To address this, what if we introduce the concept of dependencies to RECOVERY_CODES? Some codes are only considered recoverable if they occur alongside another code? In this case, TS7010 is only recoverable if there is also a code TS2391: Function implementation is missing or not immediately following the declaration. or TS1005: "')' expected.", "'}' expected."

[cspotcode]

@d9k I've implemented the dependency mechanism. Can you test and ensure this still covers your use-case?

[cspotcode]

@d9k Friendly ping to please test this code change and verify that it still solves your use-case.

[cspotcode]

@d9k have you had a chance to look at this? If not, will you be able to look at it at any point in the future?