Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement allowJs, change diagnostics option #129

Merged
merged 1 commit into from
Jun 11, 2016
Merged

Conversation

blakeembrey
Copy link
Member

@blakeembrey blakeembrey commented Jun 11, 2016

Changing the method of getting diagnostics results in a huge speed-up. The old method was implemented for some reason or another (I think it was so all diagnostics would print or something) but I think the speed-up negates that. Here's the speed test before and after with typings-core.

npm run test-spec  28.59s user 0.93s system 92% cpu 31.925 total

npm run test-spec  8.50s user 0.65s system 72% cpu 12.548 total

Closes #123.

@coveralls
Copy link

coveralls commented Jun 11, 2016

Coverage Status

Coverage decreased (-0.3%) to 87.907% when pulling 3a9a580 on allow-js into e988879 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants