Allow environment variable to override default config. #112
Conversation
| @@ -130,7 +130,7 @@ const DEFAULT_OPTIONS: Options = { | |||
| */ | |||
| export function register (opts?: Options) { | |||
| const cwd = process.cwd() | |||
| const options = extend(DEFAULT_OPTIONS, { project: cwd }, opts) | |||
| const options = extend(DEFAULT_OPTIONS, opts) | |||
There was a problem hiding this comment.
Please just re-order the parameters here. We don't want cwd coming from two places.
There was a problem hiding this comment.
@blakeembrey I don't think re-ordering will work. The testing that I did showed "extend" would overlay an "undefined" if provided. So if DEFAULT_OPTIONS was overlayed on top of {project:cwd} and no environment variable was set, then the options would end up with undefined in project. I could move it down into this method and say "if (!options.project) { options.project = cwd; }" but that seemed less straightforward than putting it in the initialization of DEFAULT_OPTIONS. Thoughts?
There was a problem hiding this comment.
You're absolutely right! Sorry I missed that yesterday. In that case, I think it's good 👍
|
Thanks for the catch, I only have the one comment. |
While attempting to override the TS_NODE_PROJECT environment variable for use with gulp, which uses 'ts-node/register', I found that the environment variable did not actually override the default config. It does now. :)