Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting lost when using tuples #614

Closed
bgrieder opened this issue Sep 24, 2015 · 3 comments
Closed

Syntax highlighting lost when using tuples #614

bgrieder opened this issue Sep 24, 2015 · 3 comments

Comments

@bgrieder
Copy link

Definition File
Atom: 1.0.16
atom-typescript: 6.0.17
all themes

class Test {

    breaks = (ok: string, notOk: [string, string]): void => {}

}

screen shot 2015-09-24 at 09 36 06

EDIT

atom-typescript 6.0.17 really doesn't like tuples :)

type Tuple = [string, string]

breaks syntax highlighting of the code that follows

EDIT 2
This problem does not exist with atom 1.0.15

@bgrieder bgrieder changed the title Syntax highlighting lost when using tuples in function parameters Syntax highlighting lost when using tuples Sep 24, 2015
@sgal
Copy link
Contributor

sgal commented Sep 24, 2015

Same problem goes for function argument's default value

Atom: 1.0.16
atom-typescript: 6.0.17
all themes

private makeTransitionSequence(preAnimations: any[],
                               duration : number = 2,
                               callback : any = this.transitionDone,
                               callbackScope : any = this) : TimelineMax {
    return new TimelineMax();
}

screen shot 2015-09-24 at 10 46 35 am

@basarat
Copy link
Member

basarat commented Sep 25, 2015

This has happened due to changes in atom 1.0.16.

This issue is an extension of #611 (comment)

@basarat
Copy link
Member

basarat commented Oct 4, 2015

@basarat basarat closed this as completed Oct 4, 2015
@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants