Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting lost in definition file when using extends followed by implements #613

Closed
bgrieder opened this issue Sep 24, 2015 · 4 comments

Comments

@bgrieder
Copy link

Definition File
Atom: 1.0.16
atom-typescript: 6.0.17
all themes

screen shot 2015-09-24 at 08 42 20

declare module "highlighting" {

    export interface I {}

    export class E0 extends Error {
        OK: string
    }
    export class E1 extends Error implements I {}
    export class E2 extends Error {
        NotOK: string
    }
}
@basarat
Copy link
Member

basarat commented Sep 25, 2015

Atom: 1.0.16

Broke with this atom release. Also #611 (comment) and #614

@basarat
Copy link
Member

basarat commented Oct 4, 2015

fixed with https://github.com/TypeStrong/atom-typescript/releases/tag/v7.1.0 🌹

Note the fix is that we break type grammar rule on new lines ... so the same line might still be weird but following lines will start highlighting correctly.

screen shot 2015-10-04 at 4 03 17 pm

@basarat basarat closed this as completed Oct 4, 2015
basarat added a commit to TypeStrong/atom-typescript-examples that referenced this issue Oct 4, 2015
@peter-mach
Copy link

@basarat whats the theme/syntax theme used in your screenshots?

@basarat
Copy link
Member

basarat commented Feb 1, 2016

I now use Monokai. In fact I believe in Monokai or death 🌹:)

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants