Registrer providers using the document selector directly #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGNonofr
requested review from
gatesn,
mofux,
BroKun,
rcjsuen,
asual,
johnwiseheart,
RomanNikitenko and
azatsarynnyy
as code owners
CGNonofr
force-pushed
the
fix-provider-registration-document-selector
branch
from
03f2ad2 to
5711100
Compare
|
@CGNonofr will this PR be backward compatible with older version monaco-editor or is it dependent on the next release? |
|
I think it already works with versions from 5 years ago. The next release will only contain the right type but the code is already there |
|
Thank you for the explanation. |
|
@kaisalmen What is the next step for this PR? |
|
Are you still expecting a review from one of the reviewers? Should I review it? |
|
Usually I ask @mofux but since you are back, why not? |
|
ping? |
kaisalmen
reviewed
Mar 8, 2022
| } | ||
|
|
||
| protected createRangeSemanticTokensProvider(selector: DocumentSelector, provider: DocumentRangeSemanticTokensProvider, legend: SemanticTokensLegend): monaco.languages.DocumentRangeSemanticTokensProvider { | ||
| protected createRangeSemanticTokensProvider(provider: DocumentRangeSemanticTokensProvider, legend: SemanticTokensLegend): monaco.languages.DocumentRangeSemanticTokensProvider { |
There was a problem hiding this comment.
You no longer pass the selector here and in other functions and then the call of this.matchModel(... which does not work. See the following compliation errors:
monaco-languageclient: src/monaco-languages.ts(74,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(103,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(124,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(142,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(160,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(178,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(196,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(214,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(241,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(249,38): error TS2552: Cannot find name 'selector'. Did you mean 'Selection'?
monaco-languageclient: src/monaco-languages.ts(271,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(289,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(309,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(327,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(345,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(376,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(394,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(412,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(420,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(443,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(467,38): error TS2304: Cannot find name 'selector'.
monaco-languageclient: src/monaco-languages.ts(492,38): error TS2304: Cannot find name 'selector'.There was a problem hiding this comment.
Oh I'm confused since I manage to publish the @codingame/monaco-languageclient package, I have no idea what happened, it's fixed
@CGNonofr I am sorry, I wrote that comment some days ago, but didn't finish the review process (forgot to press the button), so you were unable to see it. |
CGNonofr
force-pushed
the
fix-provider-registration-document-selector
branch
from
5711100 to
46a6c2d
Compare
|
LGTM |
I'll let you merge it/publish then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Proper types will come with new monaco-editor release => see microsoft/monaco-editor#2985)
Some languages servers can handle multiples languages (for instance
candc++) so the document selector contains 2 items.The current code just uses the selector language and fallback to '*'
There is then 2 issues: