WI #1301 Optimize symbol table #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search for paragraphs/sections are limited to current SymbolTable. Search for variables are limited to scope GlobalStorage. Search for functions/types in all scopes.
Put Count of IEnumerable on a temporary var to avoid multiple Count
…e typedef There are 2 separate method to seach variables: - Variable outside typedef with a simple algo - Variable inside typedef with a complex algo Code separation make it easier to understand and increase performance for code without typedef.
GetType is intented fot find a TypeDefinition. TypeDefinition is from Cobol2002 or above so there is no need to search for a TypeDefinition if the dataType is Cobol85.
Speed up lookup of variables inside typedef. Rewrite algorithm to avoid multiple enumeration of list
… result list passed as arguments This avoid to create multiple list especially when there is no symbol found in the current SymbolTable
…pedef Do not search for type reference for DataDefinition outside typedef.
…ller/unnamed symbol Check node name instead of QualifiedName. This improve performance for all unused variable. For used variables, QualifiedName can be still be used elsewhere in the code.
smedilol
added
Enhancement
User Visible
smedilol
added this to the v1.3 Codegen refacto / data size / generation with nested / formalized comment milestone
maxime645
approved these changes
Mar 14, 2019
mayanje
approved these changes
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues : #1294 #1301 #1302 #1114
Here's a first set of optimization mainly focused on SymbolTable and one commit about TypeCobolLinker.
You can look at each commit separatly to understand the optimization done.
Gain obtained on each performance test:
Note : One of the major optimization is only valid for unused variables.
So depending on the source file, you won't get the same result.