WI #1186 Generic CodeElement property on Node #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts from Compiler.Nodes.ProcedureStyleCall Codegen.Nodes.ProcedureStyleCall inherited from Compiler.Nodes.Call which was the base class for standard Cobol 85 call.
…rived type on subclass of Node
ITypedNode duplicates DataDefinition properties and is only implemented by this class
As CodeElement property of Node is now of the good type cast are useless
smedilol
added this to the v1.3 Codegen refacto / data size / generation with nested / formalized comment milestone
mayanje
approved these changes
Mar 5, 2019
maxime645
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to have the return type of Node.CodeElement property to be of the most derived type.
Extension method CodeElement() which does the same by relying only on cast has been removed.
All unnecessary casts of Node.CodeElement have been removed.
I also removed the ITypedNode interface (#1289)