Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI #1247 Remove useless track of events #1280

Merged
merged 1 commit into from
Feb 15, 2019
Merged

WI #1247 Remove useless track of events #1280

merged 1 commit into from
Feb 15, 2019

Conversation

maxime645
Copy link
Contributor

On a source that used to take 30 seconds to generate, we win 5 to 8 seconds

@maxime645 maxime645 self-assigned this Feb 12, 2019
@mayanje
Copy link
Contributor

mayanje commented Feb 12, 2019

Rather than remove it totally, maybe we can use a C# Directive like:
#if USE_TELEMETRY
......
#endif

@smedilol
Copy link
Contributor

No, it'll just be dead code that is never gonna be activated.
If we want to revert the event, we can revert the commit.

@maxime645 maxime645 merged commit 7bc1522 into develop Feb 15, 2019
@maxime645 maxime645 deleted the 1247_Kibana branch February 15, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smedilol smedilol smedilol approved these changes

@mayanje mayanje mayanje approved these changes

Assignees

@maxime645 maxime645

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxime645 @mayanje @smedilol