-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.2.1 #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f properties on DataDefinition Node
OrdinalIgnoreCase for StringComparison
Updated Visit(Move move) overriden method
- With and without Sequence numbers - Invalid part1 (wrong line for others parts) - Empty file Also remove an invalid test in Argument file.
Issue #1021 Changed culture from InvariantCultureIgnoreCase to
…but now for the call of public proc from private proc (C# hard coded translation without skeleton.xml use). #991
Issue #996 - Removed unused code in CheckVariable
collarbe
approved these changes
Jul 10, 2018
mayanje
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release mainly fix problems about code generation and provide minors performances improvements.
Codegen
Procedure with parameter and COPY Replacing at the end of linkage is not generated correctly #1014 Procedure with parameter and COPY Replacing at the end of linkage are now generated correctly
Generated code with long 'if' is generated after col 72 #1016 Long generated line could end after column 72.
These lines were split but they started at the same column of the original TypeCobol line. Thus we could still end with token after column 72.
Now if a line still end after column 72 after a split, it's pushed to the left.
Bug with qualified index in type used with occurs #1017 Fix problem with qualified index that was generated at bad location when used in a type with an occurs.
Codegen can be inserted between 2 dependent lines #991 Codegen can split lines that must stay together:
This issue is partially fixed in this milestone.
We'll rewrite a part of code generation without Razor (#1028), after that the issue #991 can be fixed properly
Performance
Improvements will be visible in our RDZ client (for errors and completion in real time).
During code generation, difference will be very small.
Misc