Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure Razor performance and look for an alternative #615

Closed
smedilol opened this issue Jul 19, 2017 · 1 comment
Closed

Measure Razor performance and look for an alternative #615

smedilol opened this issue Jul 19, 2017 · 1 comment
Assignees
@mayanje
Labels
Codegen Enhancement
Milestone
v1.3 Codegen refa...

Comments

@smedilol
Copy link
Contributor

smedilol commented Jul 19, 2017 •
edited
Loading

It seems that razor is not fast enough. It generates temp files to generate skeleton.
We need to see how "fast/slow" razor really is and look for an alternative.

One possibility is to generate the code directly in C#.
Our skeletons are not complicated.

Edit: Study http://www.stringtemplate.org/
@smedilol smedilol added this to the CodeElement/Node refactoring milestone Jul 19, 2017
smedilol added a commit that referenced this issue Aug 25, 2017
@smedilol
Issue #615 and #243, grammar test now accept a skeleton path.
f70e7c0 
So our private tests can now generate the code with our skeleton.
smedilol added a commit that referenced this issue Aug 25, 2017
@smedilol
Issue #615 and #243, GrammarTest now list CodeGen diagnostics.
4746e7e 
Added an error counter for these Diagnostics.
smedilol added a commit that referenced this issue Aug 25, 2017
@smedilol
Issue #615 and #243, some exception caught during generation are now …
3941574 
…reported as diagnostics and will not crash all codegen
@smedilol smedilol mentioned this issue Sep 8, 2017
Closed
@mayanje
Copy link
Contributor

mayanje commented Jan 9, 2019

Ok according to #1028, this issue is now obsolete

@maxime645 maxime645 mentioned this issue May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayanje mayanje

Labels
Codegen Enhancement
Projects
None yet
Milestone
v1.3 Codegen refacto / data size / ge...
Development

No branches or pull requests
2 participants
@smedilol @mayanje