Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent menu button from disappearing after fast clicks on DragHandleButton #1184

Merged

Conversation

hoongding
Copy link
Contributor

@hoongding hoongding commented Oct 25, 2024

fix #1183

AS-IS

2024-10-25.17.58.08.mov

TO-BE

2024-10-25.17.57.05.mov

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Nov 18, 2024 5:20pm
blocknote-website ✅ Ready (Inspect) Visit Preview Nov 18, 2024 5:20pm

Copy link

vercel bot commented Oct 25, 2024

@hoongding is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@hoongding hoongding changed the title fix: add show state control in freezeMenu fix: add show state control in freezeMenu method Oct 25, 2024
@hoongding hoongding changed the title fix: add show state control in freezeMenu method fix: Prevent menu button from disappearing after fast clicks on DragHandleButton Nov 13, 2024
@hoongding hoongding changed the title fix: Prevent menu button from disappearing after fast clicks on DragHandleButton fix: Prevent menu button from disappearing after fast clicks on DragHandleButton Nov 13, 2024
@hoongding
Copy link
Contributor Author

@YousefED @matthewlipski
Can I ask for a PR review?

@matthewlipski matthewlipski merged commit 6239f98 into TypeCellOS:main Nov 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I click the DragHandleButton quickly, menu button is disappear
2 participants