Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bottom over scroll to blank #102

Merged
merged 6 commits into from
May 21, 2021

Conversation

HuixingWong
Copy link
Contributor

Currently StatusScene page use Modifier.fillParentMaxHeight() as bottom spacer will cause excessive scrolling until blank

@Tlaster
Copy link
Contributor

Tlaster commented May 19, 2021

It's better to have a custom measurement for the last item in the StatusScene since we want to display the last item at least fill the height of the screen. And it's on the roadmap but not implemented yet.

@HuixingWong
Copy link
Contributor Author

It's better to have a custom measurement for the last item in the StatusScene since we want to display the last item at least fill the height of the screen. And it's on the roadmap but not implemented yet.

Currently the effect should be consistent with your description

Copy link
Contributor

@Tlaster Tlaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tlaster Tlaster merged commit 86d43da into TwidereProject:develop May 21, 2021
@HuixingWong HuixingWong deleted the fix_over_scroll branch May 21, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants