Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the file layout #24

Open
JJ opened this issue Dec 31, 2019 · 2 comments
Open

Refactor the file layout #24

JJ opened this issue Dec 31, 2019 · 2 comments

Comments

@JJ
Copy link
Collaborator

JJ commented Dec 31, 2019

Right now CSV.pm (maybe it should be pm6 by now, or even rakumod) includes everything. And I mean everything. RangeSet, IO::String (?)

this should probably get a module all by itself

CVS::Row... Lots of things. It's not a big deal, but it might make stuff easier to document, handle and, well, refactor.

Also, lots of files in the root directory; they could probably be moved out of the way, to some "benchmarks" folder or some such. That would also help to check what we still need from them...

@Tux
Copy link
Owner

Tux commented Dec 31, 2019

I like it in the same file, but this specific class could maybe do with its own file

JJ added a commit to JJ/CSV that referenced this issue Dec 31, 2019
JJ added a commit that referenced this issue Dec 31, 2019
Takes IO::String out of the big file refs #24
@JJ
Copy link
Collaborator Author

JJ commented Oct 23, 2023

IO::String is already out and refactored, file names are changed. I'll see if anything else can be done here and probably close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants