Use values_as_in_model to extract the parameters from a Transition
#2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than `invlink` + `values_as`
chains properly
…rfjelde/getparams-fix
|
This PR depends on features introduced after the breaking release of DPPL and so tests will not pass until #2202 has gone through |
|
For reference: used the new |
Pull Request Test Coverage Report for Build 8968103177Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@yebai @devmotion tests are passing and everything seems good. You happy with it? I'd also like to point to #2215 |
yebai
approved these changes
May 6, 2024
sethaxen
added a commit
to mhauru/Pathfinder.jl
that referenced
this pull request
Jul 4, 2024
Ensures `getparams` uses the changes introduced in TuringLang/Turing.jl#2202
sethaxen
added a commit
to mlcolab/Pathfinder.jl
that referenced
this pull request
Aug 16, 2024
* Add support for Turing v0.33 * Bump Turing compat for docs and tests * Fix Turing compat format * Add and test utility to create a LogDensityProblem * Add utility for converting draws to chains * Use draws_to_chains utility * Remove now-unused `flattened_varnames_list` utility * Simplify Turing integration using LogDensityProblems * Bump compat lower bounds for mutual compatibility * Bump Turing lower bounds Ensures `getparams` uses the changes introduced in TuringLang/Turing.jl#2202 * Reorganize Turing tests * Bump DynamicPPL lower bound * Also add Chains to individual paths in multipathfinder result * Test additional models * Remove unused method * Bump AdvancedHMC integration test compat to AHMC v0.6 * Increment patch number --------- Co-authored-by: Seth Axen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2195 and TuringLang/DynamicPPL.jl#588