-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default impls for filldist
and arraydist
#264
Added default impls for filldist
and arraydist
#264
Conversation
@yebai @devmotion should be quick merge |
Maybe add (non-AD?) tests? |
Co-authored-by: David Widmann <[email protected]>
Ah yes good point! |
You happy with it now @devmotion ? |
Could add some checks of the return values but probably not too relevant in this case here. |
It seems the new functions are simply an alias for product_distribution constructors so they should probably be already tested in Distributions.jl |
* fix for linking higher dimensional `Dirichlet` * bump patch version * bump Bijectors compat entry * added tests for high-dim Dirichlet * added `reconstruct` for `ArrayLikeVariate` * don't test functionality that relies on TuringLang/DistributionsAD.jl#264 yet * Update test/linking.jl * Update test/linking.jl * Update test/linking.jl --------- Co-authored-by: Hong Ge <[email protected]>
Currently we don't support something like
filldist(Dirichlet(ones(2)), 3, 4)
even though there is a distribution impl available in Distributions.jl throughproduct_distribution
.This PR adds such default impls for high-dim calls to
filldist
andarraydist
; AD might be worse performance-wise but we should still support it.TuringLang/Turing.jl#2190