Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing logpdf #256

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fix missing logpdf #256

merged 2 commits into from
Aug 4, 2023

Conversation

yebai
Copy link
Member

@yebai yebai commented Aug 4, 2023

Fix errors observed in TuringGLM.

@yebai
Copy link
Member Author

yebai commented Aug 4, 2023

Feel free to merge and make a release if CI passes.

@storopoli
Copy link
Member

Thanks, I've been trying to find the source of the errors for the past weeks with no success...

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have some tests that would have caught the issue, the lazy extension is severely under-tested. Maybe we should open an issue?

In any case, the fixes seem good.

@yebai yebai merged commit 5847e86 into master Aug 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix branch August 4, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants