Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the HMC(eps, n_leapfrog) as a convenience constructor #341

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add back the HMC(eps, n_leapfrog) as a convenience constructor #341

merged 4 commits into from
Jul 27, 2023

Conversation

yebai
Copy link
Member

@yebai yebai commented Jul 27, 2023 •
edited
Loading

Our doc string still contains the old HMC(eps, N) constructor, so let's actually define it.

AdvancedHMC.jl/src/constructors.jl

Line 109 in 8429077

HMC(ϵ::Real, n_leapfrog::Int)

torfjelde
torfjelde previously approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for this? See test/constructors.jl and add it to the list there.

@yebai
Copy link
Member Author

yebai commented Jul 27, 2023

Added a test for this constructor in 966076f

@yebai yebai merged commit 762e55f into master Jul 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the hg/one-more-hmc branch July 27, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaimeRZP JaimeRZP JaimeRZP approved these changes

@torfjelde torfjelde torfjelde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yebai @torfjelde @JaimeRZP