Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon-smooth crashes when dealing with MultiPolygons including more than one polygon with hole(s) #2323

Closed
Pitouli opened this issue Aug 16, 2022 · 1 comment

Comments

@Pitouli
Copy link
Contributor

Pitouli commented Aug 16, 2022

For example, if you test on this MultiPolygon, it will crashes:

{
  "type": "MultiPolygon",
  "coordinates": [
    [
      [
        [102.0, 2.0],
        [103.0, 2.0],
        [103.0, 3.0],
        [102.0, 3.0],
        [102.0, 2.0]
      ]
    ],
    [
      [
        [100.0, 0.0],
        [101.0, 0.0],
        [101.0, 1.0],
        [100.0, 1.0],
        [100.0, 0.0]
      ],
      [
        [100.2, 0.2],
        [100.8, 0.2],
        [100.8, 0.8],
        [100.2, 0.8],
        [100.2, 0.2]
      ]
    ],
    [
      [
        [105.0, 0.0],
        [106.0, 0.0],
        [106.0, 1.0],
        [105.0, 1.0],
        [105.0, 0.0]
      ],
      [
        [105.2, 0.2],
        [105.8, 0.2],
        [105.8, 0.8],
        [105.2, 0.8],
        [105.2, 0.2]
      ]
    ]
  ]
}

I found the issue and I am sending a PR (I simply create this ticket to link the PR to it)

rowanwins added a commit that referenced this issue Oct 6, 2022
* Fix polygon-smooth was crashing when dealing with MultiPolygons including more than one polygon with hole(s) (#2323)

* Move rollup.config in folder so the package can be used with https://gitpkg.vercel.app/

* Add the files required for using the forked package

* Make the fork usable

* Remove changes to rollup and and ts

Co-authored-by: Rowan Winsemius <[email protected]>
@rowanwins
Copy link
Member

Resolved by #2324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants