Dev checkpt load #63
Merged
Dev checkpt load #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haydnspass
reviewed
Feb 20, 2021
|
@ASpeiser Have you checked what happens with tensorboard? |
|
I'm having difficulties generally and often need to restart TB for it to update the data. But when I tried chekpointing it did work fine so I don't think it makes it any worse. |
Haydnspass
reviewed
Mar 9, 2021
| if debug: | ||
| experiment_path.mkdir(exist_ok=True) | ||
| else: | ||
| experiment_path.mkdir(exist_ok=False) | ||
|
|
||
| model_out = experiment_path / Path('model.pt') | ||
| ckpt_path = model_out.parent / Path('ckpt.pt') |
There was a problem hiding this comment.
ckpt_path should not be hard coded to ckpt.pt relative to the model.
Ckpt_path should be inferred from param.InOut.checkpoint_init (will probably require a bit of logic here).
|
Hello @ASpeiser! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-03-18 20:45:25 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.