Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading liked posts from a date range doesn't work #401

Closed
thomas694 opened this issue Dec 1, 2022 Discussed in #400 · 2 comments
Closed

Downloading liked posts from a date range doesn't work #401

thomas694 opened this issue Dec 1, 2022 Discussed in #400 · 2 comments
Labels
bug Something isn't working

Comments

@thomas694
Copy link
Contributor

thomas694 commented Dec 1, 2022

Discussed in #400

Originally posted by Zhiro90 November 30, 2022
After authenticating, I'm trying to archive my likes from the beginning of my tumblr (2010~) to 2012~, but after messing around with the FROM/TO fields (with proper yyyymmdd format) it still downloads my most recent likes, with a few old likes thrown in.

I've tried
FROM:(blank) TO:20120101,
FROM:20070606 TO:20120101
FROM:20110101 TO:20120101

and all of them start downloading 2022 posts.

Am I doing something wrong?


There's a problem, because the chosen date is used for pagination, but Tumblr compares it against the date the post was liked, while TumblThree uses the date for filtering (post date). We have to consider that and change the way TumblThree is doing it a bit.

What does a user expect from this start and end date here (ignoring the tooltip)? The date range the posts were liked or the date range the posts have been published? The latter somehow requires scanning always through all the liked posts.

@thomas694 thomas694 added the bug Something isn't working label Dec 1, 2022
thomas694 added a commit that referenced this issue Dec 4, 2022
- Tumblr's pagination timestamp is referring to the date the post was like and not the post date itself. So using start and end date for pagination and filtering by post date at the same time cannot work.
@thomas694
Copy link
Contributor Author

Tumblr's pagination timestamp is referring to the date the post was liked and not the post date itself. So using start and end date for pagination and filtering by post date at the same time couldn't work.

@thomas694
Copy link
Contributor Author

The issue has been fixed and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant