Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

First letter of plugin name gets "eaten" when updating file #29

Closed
guywiz opened this issue Dec 15, 2017 · 2 comments
Closed

First letter of plugin name gets "eaten" when updating file #29

guywiz opened this issue Dec 15, 2017 · 2 comments

Comments

@guywiz
Copy link

guywiz commented Dec 15, 2017

I use the plugin editor to load a plugin "MyPlugin" and register it (I sometimes need or want to register just as a one-shot). I go to an external editor to fix an error syntax, let's say.

When getting back to the Tulip plugin editor, I am asked whether I want to update the "MyPlugin.py" file. I click "Yes". The file gets updated. When clicking "Register plugin", I get a python error message "ImportError: No module named yPlugin" -- the first letter of the file name disappeared!

I experienced this quite a number of times, with different files. I thought I would mention it.

anlambert added a commit that referenced this issue Dec 15, 2017
@anlambert
Copy link
Contributor

Hi Guy,

Thanks for spotting this. Fixed in 1175b48.

anlambert added a commit that referenced this issue Dec 15, 2017
@guywiz
Copy link
Author

guywiz commented Dec 15, 2017

Thanks Antoine for taking care of this so fast. I came across this while giving a two days tutorial lesson on Tulip at the Lausanne (Switzerland) Criminal Science school. The colleagues will all appreciate Tulip’s next release!

p-mary referenced this issue in anlambert/talipot Jan 3, 2020
QOpenGL module is marked as deprecated since a while now so it is time
to remove its use from the Talipot codebase and promote the use of
QOpenGL* classes directly integrated in the QtGui module.

The big difference between QOpenGL and QtOpenGL from Qt5 is that all
rendering is performed in framebuffer objects, there is no more direct
rendering in the underlying os windows with its own OpenGL context.

Talipot OpenGL rendering also follows that idiom, all renderings are performed
offscreen using a shared OpenGL context. This also means that there is no
more QGLWidget as viewport for QGraphicsView. Talipot OpenGL scene are
now converted to QImage in order to display them using the default Qt raster
rendering engine. This should fixes the numerous rendering glitches observed
on MacOS.

First thing observed after the migration is a consequent performance boost
in OpenGL rendering when using an Intel GPU on a Linux host machine (especially
when selecting elements, it is now 10 times faster on debian stable).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants