This repository has been archived by the owner on Mar 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #73 from anlambert/travis-xenial-migration
TravisCI: Migrate Linux builds from trusty to xenial
Showing
19 changed files
with
169 additions
and
223 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
b658a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Why modifying interactors? They were working well previously. Tulip now crashes on exit. construct() is called on interactor when destroying them (normal behavior which should not be changed). setConfigurationWidgedText should not be called.
tulip_perspective: /home/bruno/tulip/library/tulip-gui/src/NodeLinkDiagramComponentInteractor.cpp :38 : void tlp::NodeLinkDiagramComponentInteractor::setConfigurationWidgetText(const QString&): l'assertion « _label == nullptr » a échoué.
TLP_PLATEFORM linux
TLP_ARCH x86_64
TLP_COMPILER gcc
TLP_VERSION 5.3.0-dev
TLP_STACK_BEGIN
#00 0x00007f9369c827eb in gsignal (+0x10b) from /lib64/libc.so.6
#1 0x00007f9369c84051 in abort (+0x151) from /lib64/libc.so.6
#2 0x00007f9369c7a34a in ?? (+0x2e34a) from /lib64/libc.so.6
#3 0x00007f9369c7a3d2 in ?? (+0x2e3d2) from /lib64/libc.so.6
#4 0x00007f9377acc26b in tlp::NodeLinkDiagramComponentInteractor::setConfigurationWidgetText(QString const&) (+0x51) at /home/bruno/tulip/library/tulip-gui/src/NodeLinkDiagramComponentInteractor.cpp:38 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#5 0x00007f93217f549e in InteractorNavigation::construct() (+0xfa) at /home/bruno/tulip/plugins/interactor/InteractorNavigation.cpp:50 from /usr/local/lib64/tulip/interactor/libInteractorNavigation-5.3.0-dev.so
#6 0x00007f9377b7fe0c in tlp::InteractorComposite::setView(tlp::View*) (+0x44) at /home/bruno/tulip/library/tulip-gui/src/InteractorComposite.cpp:74 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#7 0x00007f9377b77f07 in tlp::View::~View() (+0xd3) at /home/bruno/tulip/library/tulip-gui/src/View.cpp:47 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#8 0x00007f9377b7d55f in tlp::ViewWidget::~ViewWidget() (+0x10d) at /home/bruno/tulip/library/tulip-gui/src/ViewWidget.cpp:75 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#9 0x00007f9377a872ee in tlp::GlMainView::~GlMainView() (+0x12a) at /home/bruno/tulip/library/tulip-gui/src/GlMainView.cpp:49 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#10 0x00007f9377abd561 in tlp::NodeLinkDiagramComponent::~NodeLinkDiagramComponent() (+0xd9) at /home/bruno/tulip/library/tulip-gui/src/NodeLinkDiagramComponent.cpp:57 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#11 0x00007f9377abd58e in tlp::NodeLinkDiagramComponent::~NodeLinkDiagramComponent() (+0x18) at /home/bruno/tulip/library/tulip-gui/src/NodeLinkDiagramComponent.cpp:63 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#12 0x00007f9377b8157e in tlp::WorkspacePanel::~WorkspacePanel() (+0xd8) at /home/bruno/tulip/library/tulip-gui/src/WorkspacePanel.cpp:132 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#13 0x00007f9377b815d2 in tlp::WorkspacePanel::~WorkspacePanel() (+0x18) at /home/bruno/tulip/library/tulip-gui/src/WorkspacePanel.cpp:136 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#14 0x00007f9377b8f225 in tlp::Workspace::closeAll() (+0xa1) at /home/bruno/tulip/library/tulip-gui/src/Workspace.cpp:127 from /usr/local/bin/../lib64/libtulip-gui-5.3.so
#15 0x00007f93231b9957 in GraphPerspective::~GraphPerspective() (+0xbd) at /home/bruno/tulip/plugins/perspective/GraphPerspective/src/GraphPerspective.cpp:266 from /usr/local/lib64/tulip/perspective/libGraphPerspective-5.3.0-dev.so
#16 0x00007f93231b9ad0 in GraphPerspective::~GraphPerspective() (+0x18) at /home/bruno/tulip/plugins/perspective/GraphPerspective/src/GraphPerspective.cpp:278 from /usr/local/lib64/tulip/perspective/libGraphPerspective-5.3.0-dev.so
b658a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to close Tulip : Open a node link view and just try to close it (in Debug mode)
b658a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explanation is in the commit log (hang when running unit tests on ubuntu with Qt >= 5.10)
Will look how to fix this, this should be simple.
b658a63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so replacing those lines: https://github.com/Tulip-Dev/tulip/blob/master/library/tulip-gui/src/NodeLinkDiagramComponentInteractor.cpp#L37-L43 by
should be enough to fix the observed issue. I let you validate and commit.