Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chromatic Deployment #2644

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Fix Chromatic Deployment #2644

merged 11 commits into from
Oct 28, 2024

Conversation

adrastaea
Copy link
Collaborator

@adrastaea adrastaea commented Oct 24, 2024

Largely reverting unnecessary changes to babel dependencies from #2597 that broke build-storybook. @babel/runtime is left added to dependencies on logger and common because without it some module interop helper needed is not found during mobile tests.

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@adrastaea adrastaea requested a review from islathehut October 24, 2024 16:44
@adrastaea adrastaea linked an issue Oct 24, 2024 that may be closed by this pull request
@adrastaea adrastaea marked this pull request as ready for review October 24, 2024 17:10
bootstrap all packages for mobile build

add @babel/runtime to logger

add to common

restore limited bootstrap

drop added line

fix "

update changelog
@adrastaea adrastaea merged commit 434dfda into develop Oct 28, 2024
29 of 33 checks passed
@adrastaea adrastaea deleted the fix/chromatic-build branch October 28, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chromatic deploy action is broken
2 participants