Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2602 Move Identity model to backend #2617

Merged
merged 39 commits into from
Nov 1, 2024
Merged

Conversation

adrastaea
Copy link
Collaborator

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@adrastaea adrastaea marked this pull request as ready for review October 16, 2024 20:35
@adrastaea adrastaea requested a review from islathehut October 28, 2024 15:04
Copy link
Collaborator

@islathehut islathehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall on first pass. Gonna come back in a bit to give it a second pass.

Copy link
Collaborator

@islathehut islathehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrastaea adrastaea merged commit 7a27956 into develop Nov 1, 2024
29 of 32 checks passed
@adrastaea adrastaea deleted the 2602-move-id-model-to-backend branch November 1, 2024 14:59
islathehut pushed a commit that referenced this pull request Nov 18, 2024
* replace network refs in conn-man with identity

* move identity and usercsr creation to backend

* use backend identity when creating community

* fix user certs not being updated

* rm identity from initcommunitypayload

* Refactor storage service to handle CSR saving errors before init

* add identity directly

* add identity directly in createNetwork

* move identity creation after invite code parsing

* fix deep linking test

* fix loadingPanel.test.tsx

fix types in CREATE_USER_CSR chain

fix loadPanel test better

remove mocked socket test

fix community.create test

add identity type for usercsr init

* fix last desktop rtl tests

* fix registerUsername.saga.test

* skip backwards compatibility tests not on linux

* skip outdate integration tests

* fix conn-serv.spec.test

* fix dialing tests

* remove unused socket actions

* remove my personal scripts

* exclude local address from libp2p peers

* update mobile deep link snapshot

* don't resave csr when community is opened from storage

* rm extraneous logging and imports

* add identities to migration

* fix key type

* cherry pick storybook fix

* ensure csr is saved when updating username

* update changelog

* fix state-manager tests

* make missing identity when launching community from storage a warning

* fix log comment

* update package.lock

* put update in chores section

* add back in build:auth

* use the correct implementation of build:auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants