Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user profile area should be clickable #2566 #2595

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

okrayum
Copy link
Contributor

@okrayum okrayum commented Aug 7, 2024

This PR addresses issue #2566 by ensuring that the entire user profile area in the sidebar is clickable.

  • Moved padding from the parent container to the button to ensure that the button area is fully clickable while maintaining the same size and style.
  • Updated the hover state to apply to the entire button area.

This shows the previous next to after the changes I made:

Screen.Recording.2024-08-07.121213.mp4

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

This PR closes #2566

@holmesworcester
Copy link
Contributor

Thank you! I just approved tests to run. It might be necessary to fix e2e or snapshot tests, but possibly not!

@okrayum
Copy link
Contributor Author

okrayum commented Aug 8, 2024

@holmesworcester , ok thank you! I already see some checks failed.

@holmesworcester
Copy link
Contributor

Will you have a look and fix them? It should be straightforward and please let us know if not!

Thanks again for the initial contribution ❤️

@okrayum
Copy link
Contributor Author

okrayum commented Aug 9, 2024

Yes, I will check them now. Thanks!
@holmesworcester , I see the first failure as simple, the others I may need some guidance on if possible.
Thanks!

@okrayum
Copy link
Contributor Author

okrayum commented Aug 12, 2024

I have addressed previous failing checks, let me know please.
Thanks!

@okrayum
Copy link
Contributor Author

okrayum commented Aug 12, 2024

I'm unsure where I am going wrong with the failing checks. This is what I have for the current 4 that are showing as failing.

  1. Check / check (ubuntu-20.04) (pull_request) , I have made sure the semicolon is no longer there.
    Screenshot 2024-08-12 154157
    Screenshot 2024-08-12 152101

  2. Dependency Review / dependency-review (pull_request), this was not changed.

  3. Desktop scroll regression tests / regression-tests (ubuntu-20.04) (pull_request), the tests now should pass.
    Screenshot 2024-08-12 152025

  4. Desktop tests / desktop-tests (ubuntu-20.04) (pull_request), the tests now should pass.
    Screenshot 2024-08-12 153509

@holmesworcester
Copy link
Contributor

Sorry for the friction here and thanks for looking into it. @ikoenigsknecht will look at this today!

@okrayum
Copy link
Contributor Author

okrayum commented Aug 13, 2024

Sounds good thank you very much. It seems like my last commit didn't take any of the staged changes. They are showing now, so I'm anxious to see how they do with the checks. I appreciate it!

@okrayum
Copy link
Contributor Author

okrayum commented Aug 15, 2024

Hello @ikoenigsknecht , let me know what i need to fix.
Thanks!

@okrayum
Copy link
Contributor Author

okrayum commented Aug 19, 2024

Hello @ikoenigsknecht, I was just curious if there was any feedback after my last fixes of the failing checks. I understand everyone is busy, so just checking in.
Thank you!

Copy link
Collaborator

@adrastaea adrastaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some seeming unrelated inclusions. I like the effect! Will approve and merge once those questions are resolved.

packages/desktop/libssl.so Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@okrayum okrayum force-pushed the clickable-user-profile-area branch from cc63f77 to 69e2f79 Compare September 6, 2024 20:15
@adrastaea adrastaea merged commit 9dfd6da into TryQuiet:develop Sep 6, 2024
24 of 28 checks passed
@okrayum
Copy link
Contributor Author

okrayum commented Sep 6, 2024

@adrastaea , Thank for all of your help!

@okrayum okrayum deleted the clickable-user-profile-area branch September 6, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entire user profile area should be clickable, in bottom left
3 participants