-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: user profile area should be clickable #2566 #2595
fix: user profile area should be clickable #2566 #2595
Conversation
Thank you! I just approved tests to run. It might be necessary to fix e2e or snapshot tests, but possibly not! |
@holmesworcester , ok thank you! I already see some checks failed. |
Will you have a look and fix them? It should be straightforward and please let us know if not! Thanks again for the initial contribution ❤️ |
Yes, I will check them now. Thanks! |
I have addressed previous failing checks, let me know please. |
Sorry for the friction here and thanks for looking into it. @ikoenigsknecht will look at this today! |
Sounds good thank you very much. It seems like my last commit didn't take any of the staged changes. They are showing now, so I'm anxious to see how they do with the checks. I appreciate it! |
Hello @ikoenigsknecht , let me know what i need to fix. |
Hello @ikoenigsknecht, I was just curious if there was any feedback after my last fixes of the failing checks. I understand everyone is busy, so just checking in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than some seeming unrelated inclusions. I like the effect! Will approve and merge once those questions are resolved.
cc63f77
to
69e2f79
Compare
…yum/quiet into clickable-user-profile-area
@adrastaea , Thank for all of your help! |
This PR addresses issue #2566 by ensuring that the entire user profile area in the sidebar is clickable.
This shows the previous next to after the changes I made:
Screen.Recording.2024-08-07.121213.mp4
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package:
This PR closes #2566