Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(2576): Update hover and selected contrast and modify sidebar color in dark mode #2579

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(2576): Update hover and selected contrast and modify sidebar color in dark mode #2579

merged 2 commits into from
Jul 29, 2024

Conversation

islathehut
Copy link
Collaborator

@islathehut islathehut commented Jul 12, 2024 •
edited
Loading

  • Updates contrast of hover and select in sidebar to match new figma designs (see attached ticket)
  • Updates sidebar background color in dark mode to match figma

Github Issue: #2576

Screen.Recording.2024-07-12.at.12.10.03.PM.mov

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@islathehut islathehut merged commit d7bf1b9 into develop Jul 29, 2024
23 of 31 checks passed
@islathehut islathehut deleted the fix-2576-sidebar-contrast branch July 29, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmesworcester holmesworcester holmesworcester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islathehut @holmesworcester