Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Use macos-12 on 2.2.0 #2515

Merged
merged 3 commits into from
May 9, 2024
Merged

Chore: Use macos-12 on 2.2.0 #2515

merged 3 commits into from
May 9, 2024

Conversation

islathehut
Copy link
Collaborator

@islathehut islathehut commented May 9, 2024 •
edited
Loading

This just pulls in Emi's changes from develop and reverts the changes I made to use arm64 images in e2e tests. This should fix the broken dmg generation on releases we've seen in the past couple of alphas.

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

EmiM and others added 2 commits May 8, 2024 19:27
@EmiM @islathehut
macos-latest -> macos-12 (#2482)
4cd24e9 
* fix: use explicit macos-12 image instead of macos-latest ('-latest' image was updated to macos-14)
@islathehut
Update e2e-mac.yml
1a26823
@islathehut islathehut changed the base branch from develop to 2.2.0 May 9, 2024 13:11
@islathehut islathehut marked this pull request as ready for review May 9, 2024 13:11
@islathehut islathehut changed the title Fix mac stuff on 2.2.0 Chore: Use macos-12 on 2.2.0 May 9, 2024
@islathehut islathehut merged commit c51d29a into 2.2.0 May 9, 2024
21 of 23 checks passed
@islathehut islathehut deleted the fix-mac-stuff-on-2.2.0 branch May 9, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmiM EmiM EmiM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islathehut @EmiM