fix: Various fixes related to peers, CSRs and backend startup #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leblowl
force-pushed
the
2.2.0-various-fixups
branch
from
23b56a5 to
20fa367
Compare
EmiM
reviewed
Apr 23, 2024
|
|
||
| this.logger(`Retrieving all users. CSRs count: ${csrs.length} Certificates count: ${certs.length}`) | ||
|
|
||
| for (const cert of certs) { |
There was a problem hiding this comment.
I'm guessing that retrieving both certs and csrs is for the case when one of those DBs are not fully synced? In any other case you can't have certificate without csr.
There was a problem hiding this comment.
This mirrors how we do things on the frontend and is helpful in the case where certs replicate before csrs.
leblowl
force-pushed
the
2.2.0-various-fixups
branch
3 times, most recently
from
de56de8 to
5bebb6e
Compare
leblowl
force-pushed
the
2.2.0-various-fixups
branch
3 times, most recently
from
fb663d7 to
2bb50c4
Compare
leblowl
commented
Apr 23, 2024
| @@ -63,4 +66,6 @@ export function* launchCommunitySaga( | |||
| } | |||
|
|
|||
| yield* apply(socket, socket.emitWithAck, applyEmitParams(SocketActionTypes.LAUNCH_COMMUNITY, payload)) | |||
|
|
|||
| yield* put(identityActions.saveUserCsr()) | |||
There was a problem hiding this comment.
Add the user's CSR once after launching community.
leblowl
commented
Apr 23, 2024
| } else { | ||
| yield* put(identityActions.saveUserCsr()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Just inlining registerCertificate here to simplify things
leblowl
commented
Apr 23, 2024
| const keyObject = yield* call(loadPrivateKey, identity.userCsr.userKey, config.signAlg) | ||
| const signatureArrayBuffer = yield* call(sign, action.payload.message, keyObject) | ||
| const signature = yield* call(arrayBufferToString, signatureArrayBuffer) | ||
| const createdAt = yield* call(getCurrentTime) |
There was a problem hiding this comment.
Re-organizing a bit and adding additional logs.
leblowl
commented
Apr 23, 2024
| if (!peers) { | ||
| throw new Error('No peers provided and no peers found on current stored community') | ||
| } | ||
| } |
There was a problem hiding this comment.
Moved this logic into updatePeersList
leblowl
force-pushed
the
2.2.0-various-fixups
branch
from
2bb50c4 to
147e2c8
Compare
Fixes for the following issues: - Peers can be deleted if CSRs don't sync - Backend starting before the frontend is ready, resulting in missed events - Adding duplicate CSRs
leblowl
force-pushed
the
2.2.0-various-fixups
branch
from
147e2c8 to
73a6b09
Compare
islathehut
approved these changes
Apr 25, 2024
leblowl
pushed a commit
that referenced
this pull request
Apr 29, 2024
Fixes for the following issues: - Peers can be deleted if CSRs don't sync - Backend starting before the frontend is ready, resulting in missed events - Adding duplicate CSRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the following issues:
I found an existing bug where we could actually remove peers (originating from the invite link) from the peer list if certificates replicated before CSRs, because we used CSRs to update the peer list. @ikoenigsknecht, this could be related to the issue where you said the dialer stopped working, perhaps it didn't have any peers to dial. In the PR, we use the same definition for all users as the frontend (CSRs + certs) when finding peers and we always retain peers from the invite link even if we don't have their cert or CSR yet.
The peer issue was really easy to reproduce when CSRs didn't replicate, which I was also lucky enough to reproduce. Apparently due to our duplicate CSR issue (I had around 3670 CSRs), that caused CSRs to take 30 minutes or so to replicate. So that's interesting. It looks like we had this saga checkLocalCsr which would re-add a CSR in certain cases or not add the user's CSR at all. In the case where the CSR doesn't get added at all, we could get the disappearing message effect that @kingalg saw because we don't display messages unless we know about the user (CSR or cert must exist). In this PR, we add the CSR once (right after community is launched).
Also the backend was starting before the frontend was ready on mobile only. Thanks @EmiM for spotting that. This resulted in missing a CHANNEL_SUBSCRIBED event and thus not being able to send a message (having it greyed out indefinitely). It looks like mobile connects with native code to the backend in order to get push notifications which causes the backend to start, then the actual frontend code connects and by then it's missed the CHANNEL_SUBSCRIBED event. So I added a new START event for the frontend to explicitly tell the backend it's ready.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: