Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(1977): Fix e2e tests on windows #2454

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Chore(1977): Fix e2e tests on windows #2454

merged 2 commits into from
Apr 17, 2024

Conversation

islathehut
Copy link
Collaborator

@islathehut islathehut commented Apr 17, 2024 •
edited
Loading

  • Reorder test runs on windows so we are more likely to run the majority of tests
  • Clear out default app directory before starting invitation link tests (this is because we start the app before we run the tests and its populating with data not related to the tests and throwing things off)

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@islathehut islathehut marked this pull request as ready for review April 17, 2024 16:36
@islathehut islathehut changed the title Chore 1977 fix windows e2e tests DO NOT REVIEW: Chore 1977 fix windows e2e tests Apr 17, 2024
@islathehut islathehut force-pushed the chore-1977-fix-windows-e2e-tests branch from c1ff1cd to bc4eafc Compare April 17, 2024 18:15
@islathehut
Copy link
Collaborator Author

Fixes #1977

@islathehut islathehut changed the title DO NOT REVIEW: Chore 1977 fix windows e2e tests DO NOT REVIEW: Chore(1977): Fix e2e tests on windows Apr 17, 2024
@islathehut islathehut changed the title DO NOT REVIEW: Chore(1977): Fix e2e tests on windows Chore(1977): Fix e2e tests on windows Apr 17, 2024
@islathehut islathehut merged commit db587a4 into develop Apr 17, 2024
12 checks passed
@islathehut islathehut deleted the chore-1977-fix-windows-e2e-tests branch April 17, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@islathehut @leblowl