Fix: Not initializing on reconnection when general channel was deleted (#2334) #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s deleted while they were offline
|
Fixes #2334 |
islathehut
commented
Apr 2, 2024
Comment on lines
-614
to
-622
| const allEntries = this.getAllEventLogRawEntries(repo.db) | ||
| // const allEntries = this.getAllEventLogRawEntries(repo.db) | ||
| await repo.db.close() | ||
| await repo.db.drop() | ||
| const hashes = allEntries.map(e => CID.parse(e.hash)) | ||
| const files = allEntries | ||
| .map(e => { | ||
| return e.payload.value.media | ||
| }) | ||
| .filter(isDefined) |
There was a problem hiding this comment.
These changes were just to clean up some seemingly useless stuff. We weren't doing anything with those hashes/files so its just wasted work.
islathehut
commented
Apr 2, 2024
Comment on lines
-27
to
-37
| // Removing channels from store | ||
| if (databaseStoredChannelsIds.length > 0) { | ||
| for (const channelId of locallyStoredChannels) { | ||
| if (!databaseStoredChannelsIds.includes(channelId)) { | ||
| log(`Removing #${channelId} from store`) | ||
| yield* put(publicChannelsActions.deleteChannel({ channelId })) | ||
| yield* take(publicChannelsActions.completeChannelDeletion) | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The issue ended up being that we were deleting the old general channel before we recreated it with the new ID so the check for the presence of the new channel was happening too early. Swapping the order of operations fixes it.
leblowl
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: