fix: Add retry ability to tor-control and misc fixes #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmiM
reviewed
Mar 13, 2024
|
|
||
| this.isSending = true | ||
| await this.connect() | ||
| // FIXME: Errors are not caught here. Is this what we want? |
There was a problem hiding this comment.
Just noting that this is how it was in the previous version of this code, so I haven't changed anything
EmiM
approved these changes
Mar 13, 2024
leblowl
force-pushed
the
fix-tor-control
branch
from
8e0768e to
8b4ded5
Compare
We were getting an uncaught ECONNREFUSED exception on iOS (perhaps due to a race condition), so this commit retries until we connect. It also fixes some existing code that appeared to be broken in other ways.
leblowl
force-pushed
the
fix-tor-control
branch
from
8b4ded5 to
87cfaa2
Compare
leblowl
pushed a commit
that referenced
this pull request
Mar 13, 2024
…2360) We were getting an uncaught ECONNREFUSED exception on iOS due to the Tor control port not getting updated after the app has been resumed on iOS, so this commit fixes that and refactors the tor-control code in order to add retry ability and fix misc issues with that code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting an uncaught ECONNREFUSED exception on iOS due to the Tor control port not getting updated after the app has been resumed on iOS, so this commit fixes that and refactors the tor-control code in order to add retry ability and fix misc issues with that code.
Solution for: #2352
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: