Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle paths with whitespaces #2123

Merged
merged 24 commits into from
Jan 25, 2024
Merged

fix: handle paths with whitespaces #2123

merged 24 commits into from
Jan 25, 2024

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Nov 28, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@EmiM EmiM marked this pull request as ready for review December 5, 2023 11:08
@EmiM
fix: wrap tor path in double quotes to handle spaces in path; spawn t…
f440117 
…or in shell; kill group of processes (shell: true spawns 2 processes)
@EmiM EmiM mentioned this pull request Dec 5, 2023
Closed
@EmiM EmiM requested a review from leblowl January 25, 2024 13:26
@EmiM EmiM merged commit d7c612a into develop Jan 25, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siepra siepra siepra approved these changes

@leblowl leblowl leblowl approved these changes

Assignees

@leblowl leblowl

@Kacper-RF Kacper-RF

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EmiM @leblowl @siepra @Kacper-RF @vinkabuki