Feature/notify users about incoming backwards incompatibility #1980 #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siepra
changed the title
Nagranie.z.ekranu.2023-11-7.o.16.40.32.mov |
Kacper-RF
reviewed
Nov 8, 2023
vinkabuki
reviewed
Nov 8, 2023
There was a problem hiding this comment.
I think this should be animated, right? We should add some simple css effects to this like those arrows should spin around logo and those little stars should randomly disappear and appear
There was a problem hiding this comment.
I think let's focus that level of attention on the things people are likely to see a lot.
this particular message will only be seen:
- in this release
- in the future once we implement some notification for deprecated apps, but only for mobile users who go a very long time without autoupdates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package:
I have run e2e tests for mobileI have updated base screenshots for visual regression testsDetails
Solves #1980
I'm not adding information to CHANGELOG as it exists on
developbranch currently.I'm not fixing e2e tests as this feature will be deleted on merging
developbranch (as a part of the original issue)