Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust project bootstrap scripts to be windows-friendly #1870

Merged
merged 13 commits into from
Oct 2, 2023
Merged

Adjust project bootstrap scripts to be windows-friendly #1870

merged 13 commits into from
Oct 2, 2023

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Sep 27, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@EmiM EmiM requested review from vinkabuki and Kacper-RF September 27, 2023 17:04
@EmiM EmiM force-pushed the fix/1818-bootstrap-on-windows branch from 05f84fe to 70b23c3 Compare September 27, 2023 17:26
Kacper-RF
Kacper-RF reviewed Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Kacper-RF Kacper-RF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup environment step in E2E and check workflow failed

@EmiM EmiM marked this pull request as draft September 28, 2023 09:46
@EmiM EmiM force-pushed the fix/1818-bootstrap-on-windows branch from 70b23c3 to c874a3f Compare September 28, 2023 10:06
@EmiM EmiM force-pushed the fix/1818-bootstrap-on-windows branch from 2abf57d to 431a7a5 Compare September 28, 2023 15:37
@EmiM EmiM force-pushed the fix/1818-bootstrap-on-windows branch 2 times, most recently from 400ff94 to 258fdb5 Compare September 28, 2023 17:15
@EmiM EmiM force-pushed the fix/1818-bootstrap-on-windows branch from 258fdb5 to d3b1374 Compare September 28, 2023 21:09
@EmiM EmiM marked this pull request as ready for review September 28, 2023 21:58
leblowl
leblowl reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @EmiM!

packages/backend/package.json Show resolved Hide resolved
packages/mobile/package.json Show resolved Hide resolved
@leblowl
Copy link
Collaborator

leblowl commented Sep 29, 2023

Does this fix: #1818?

@EmiM EmiM marked this pull request as draft September 29, 2023 13:39
@EmiM EmiM marked this pull request as ready for review October 2, 2023 10:45
@EmiM EmiM mentioned this pull request Oct 2, 2023
Closed
@EmiM
Copy link
Contributor Author

EmiM commented Oct 2, 2023

@leblowl almost but I added a note to desktop readme. There still may be an issue with patch.

@vinkabuki
Copy link
Contributor

LGTM, I've tested it on my local windows machine which used to fail - now it works, I am able to open and use the app

@leblowl
Copy link
Collaborator

leblowl commented Oct 2, 2023

I'd recommend squashing commits to keep the git history cleaner on develop

@leblowl leblowl mentioned this pull request Oct 2, 2023
Open
@EmiM EmiM merged commit ced2181 into develop Oct 2, 2023
20 of 22 checks passed
@siepra siepra deleted the fix/1818-bootstrap-on-windows branch October 3, 2023 15:44
EmiM added a commit that referenced this pull request Oct 4, 2023
@EmiM
Revert "Adjust project bootstrap scripts to be windows-friendly (#1870)"
080fb79 
This reverts commit ced2181.
EmiM added a commit that referenced this pull request Oct 5, 2023
@EmiM
Revert "Revert "Adjust project bootstrap scripts to be windows-friend…
7200b0c 
…ly (#1870)""

This reverts commit 080fb79.
EmiM added a commit that referenced this pull request Oct 9, 2023
@EmiM
Revert "Adjust project bootstrap scripts to be windows-friendly (#1870)"
14c8380 
This reverts commit ced2181.
EmiM added a commit that referenced this pull request Oct 10, 2023
@EmiM
Revert "Adjust project bootstrap scripts to be windows-friendly (#1870)…
0811ea3 
…" (#1937)

* Revert "Adjust project bootstrap scripts to be windows-friendly (#1870)"

This reverts commit ced2181.

* Fix quiet binary path for windows e2e tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kacper-RF Kacper-RF Kacper-RF left review comments

@leblowl leblowl leblowl left review comments

@vinkabuki vinkabuki vinkabuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmiM @leblowl @vinkabuki @Kacper-RF