Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/replace disabling inputs with splash #1799

Merged
merged 14 commits into from
Sep 15, 2023
Merged

Chore/replace disabling inputs with splash #1799

merged 14 commits into from
Sep 15, 2023

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Sep 12, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@siepra siepra linked an issue Sep 12, 2023 that may be closed by this pull request
"Join/Create community" and "Username registration" screens are graying out input #1677
Closed
@siepra siepra marked this pull request as ready for review September 12, 2023 11:48
@siepra siepra requested a review from Kacper-RF September 12, 2023 11:48
@leblowl
Copy link
Collaborator

leblowl commented Sep 13, 2023 •
edited
Loading

Why are tests being moved to the __tests__ directory? I'm also curious why the snapshot tests are no longer using the inline snapshots?

@siepra
Copy link
Contributor Author

siepra commented Sep 14, 2023 •
edited
Loading

We don't really have any strict policy on tests appearance. I decided to use toMatchSnapshot instead of the inline one, because the snapshot is very long and it makes the test harder to read. At the same time I thought that moving it to a separate sub-location will make the whole component directory less messy

Kacper-RF
Kacper-RF reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@Kacper-RF Kacper-RF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave the version information on the splash screen until there is an "About" tab in mobile settings where the user can see the current version? I think this is important for QA and future debugging purposes.

@siepra siepra requested a review from Kacper-RF September 14, 2023 14:20
@leblowl
Copy link
Collaborator

leblowl commented Sep 14, 2023 •
edited
Loading

idea: maybe squash commits to keep the git history on develop a little cleaner/easier to undo

@siepra
Copy link
Contributor Author

siepra commented Sep 15, 2023

@leblowl I always squash, although recently I've been thinking about some more strict naming policy like prefixes etc.

@siepra siepra merged commit 1366d05 into develop Sep 15, 2023
13 checks passed
@leblowl
Copy link
Collaborator

leblowl commented Sep 15, 2023

@siepra nice, naming policy for commits? Like https://www.conventionalcommits.org/en/v1.0.0/?

@siepra siepra deleted the chore/replace-disabling-inputs-with-splash branch September 18, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kacper-RF Kacper-RF Kacper-RF approved these changes

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Join/Create community" and "Username registration" screens are graying out input
3 participants
@siepra @leblowl @Kacper-RF